feat: expose validate() as abstract #1641
Open
+17
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-pelykh
force-pushed
the
feat/expose-validate-as-abstract
branch
from
1fb5ae9
to
613f3c4
Compare
alexey-pelykh
force-pushed
the
feat/expose-validate-as-abstract
branch
from
4bd2d57
to
f586a03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
extends PassportStrategy(Strategy)does not inform developer thatvalidatemust be implement and about it's signature.What is the new behavior?
extends PassportStrategy(Strategy)informs developer thatvalidatemust be implement and about it's signature.Does this PR introduce a breaking change?
In case there are abstract classes that derive from
PassportStrategy(Strategy)that didn't markvalidate()as abstract, those would issue a build error now.Other information