fix: implement CronJon type generics #1538
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerdstep
commented
Jan 5, 2024
| import sinon from 'sinon'; | ||
| import { CronExpression } from "../../lib"; | ||
| import { CronExpression } from '../../lib'; |
There was a problem hiding this comment.
Please excuse the excess formatting changes, prettier wanted to do its thing...
Tony133
approved these changes
Jan 6, 2024
4 tasks
|
Hi team, any chance we could merge this in please? TIA 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1537
What is the new behavior?
Introduced missing type generics for CronJob.
Does this PR introduce a breaking change?
Other information