Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(application): add option: platform #1610

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

its-dibo
Copy link

@its-dibo its-dibo commented Nov 19, 2023

  • add a new option to automatically add the underlying http platform

  • add a new option to automatically install the dependencies,
    can be disabled by the user

  • add a package.script "create-app" to quickly try the application schematics.
    it creates a new application inside 'dist',
    so it is not pushed to the git repository

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

- add a new option to automatically add the underlying http platform

- add a new option to automatically install the dependencies,
 can be disabled by the user

- add a package.script "create-app" to quickly  try the application schematics.
 it creates a new application inside 'dist',
  so it is not pushed to the git repository
@micalevisk
Copy link
Member

nestjs/nest-cli#1352 (comment)

I like that option, tho

@kamilmysliwiec
Copy link
Member

Using fastify instead of express requires you to change 1 line of code and install 1 dependency (fastify instead of express). Is this really something we should be covering with schematics?

@its-dibo
Copy link
Author

Using fastify instead of express requires you to change 1 line of code and install 1 dependency (fastify instead of express). Is this really something we should be covering with schematics?

even installing the default Nestjs app requires one command dgit to clone the project skeleton, that is what the schematics already do now (moving the template files into a new dir)

however, this feature opens the aperture to add more features that requires a little bit configurations,
and for fastify, it tweeks the generated files with just one click rather that searching how to convert the http platform into fastify, that is what the schematics is created for.

@kamilmysliwiec
Copy link
Member

even installing the default Nestjs app requires one command dgit to clone the project skeleton, that is what the schematics already do now (moving the template files into a new dir)

I feel like we're comparing apples to oranges here though.

however, this feature opens the aperture to add more features that requires a little bit configurations,

Like what?

Don't get me wrong, I'm not saying this change doesn't make "any sense". My point is the more we add to the schematics package the more we have to maintain in the future (and we already have ~30 packages to maintain) so I'm just making sure that we don't add things that don't make developers' lives significantly easier

@its-dibo
Copy link
Author

I got ur point of view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants