fix(core): support non-ASCII characters in filename paths #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unescape escaped unicode characters in file paths. Filepaths returned from TypeScript have their non-ASCII characters escaped. See https://www.github.com/microsoft/TypeScript/issues/36174 This enables the use of non-ASCII characters in the project path. Closes nestjs#1868
| const unicodeRegex = /\\u([\dA-Fa-f]{4})/g | ||
|
|
||
| // Unescape escaped unicode https://github.com/microsoft/TypeScript/issues/36174 | ||
| return text.replace(unicodeRegex, (match, unicode) => { |
There was a problem hiding this comment.
I'm somewhat worried about the performance implications of this change. Are we sure we want to run this regex on every invocation of getText?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If there is a non-ASCII character in the path of a dto file this will result in failure to normalize the path.
Example of a non-ASCII character in the project path (actual/expected):
Example of a non-ASCII character in the dto folder (actual/expected):
This results in incorrect imports in the generated JavaScript.
Issue Number: Closes #1868
What is the new behavior?
The swagger plugin now supports Unicode characters in paths to dto files.
Does this PR introduce a breaking change?
Other information