Block duration option for throttler

[asif-jalil]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Other... Please describe:

What is the current behavior?

Currently, when a user exceeds their request limit within a defined time window (ttl), their requests are blocked for a fixed duration tied to the ttl.

Issue Number: 1660

What is the new behavior?

I introduced a new option called blockDuration when importing the throttler module option. If users choose not to specify blockDuration, the system will fall back to the default behavior, which relies on the ttl.

Does this PR introduce a breaking change?

• Yes
• No

Other information

[jmcdo29]

From a quick pass it looks pretty good, I'll need to go more in depth later.

One main concern of mine is that this will be a breaking change at the library level, so anyone who maintains a storage package will need to update to the new interface.

Is there any way to keep the current API, or is hat not possible with the nature of the changes?

[asif-jalil]

Yes. This will be a breaking change at the library level.

I think it's not possible to keep the current API.

[apmovamo]

@jmcdo29 This would be nice to have

[cdx111]

@asif-jalil I look forward to this feature

[asif-jalil]

@asif-jalil I look forward to this feature

@cdx111 I also look forward to this feature. But I don't know why @jmcdo29 pushed this to a long waiting list!

[cdx111]

@jmcdo29

[jmcdo29]

Apologies for the delay and thank you for your patience. It's been hectic keeping up with support and general life. I wanna revisit this and see what can be done with it, as I can tell there is a community want for this.

[asif-jalil]

@jmcdo29 is there any update?

[jmcdo29]

All right! Finally got around to reviewing this. Overall everything looks good, there's a few changes I think I'll want to make as we're already going to be making breaking changes, so it'll be a good time to do so. I also want to get @kkoomen to take a look so he's aware of the changes that will need to be made for the redis storage for this update, but otherwise this looks good, and I'd be willing to release it soon

[jmcdo29]

okay, cool, code looks great. I'll let CI run, and wait for @kkoomen to weigh in as well

[kkoomen]

@jmcdo29 Sorry for my late reply, I'm very busy lately.

I only have some minor requests in terms of docblock things. I'm not too much involved in the project but it looks fine to me for what I see. I also noticed the ttl is sometimes in millisconds and seconds, which seems inconsistent, so make sure that it is milliseconds in the right places whenever it is being mentioned that they are in ms rather than secs.

Other than that, I don't think I need to make any adjustments to my redis storage, if so, someone will probably run into an issue and submit an issue :P

[kkoomen]

Still some remaining typos and a console.log to be removed.

[kkoomen]

@jmcdo29 Looking good from my side. Up to you to merge whenever you feel like.

[asif-jalil]

@jmcdo29 is there any update for merge?