feat: Change getRepositoryToken provider generation to use getEntityManagerToken instead of getConnectionToken #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edeesis
force-pushed
the
fix-1819
branch
4 times, most recently
from
d0e43a7
to
026a183
Compare
1 task
This change will make Repository generation use getEntityManagerToken instead of getConnectionToken closes nestjs#1819
|
@kamilmysliwiec Can this be considered for merge? |
|
Thanks for your contribution @edeesis! While this is a great change and step forward, I'm afraid we should postpone merging this PR till the next major release since it sorts of introduces a breaking change (may break existing projects). |
|
Sounds good to me! No problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Changes the repository provider instantiation to use EntityManager instead of connection, allowing easier overriding.
Issue Number: #1819
What is the new behavior?
With this change, you can now override the EntityManager provider and retrieve repositories directly from there, allowing you to, for instance, start a transaction, and re-use that EntityManager instance for all inject points.
Does this PR introduce a breaking change?
Other information