Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display Script Results Instead of Job Logs #15983

Open
bitcollector1 opened this issue May 7, 2024 · 3 comments · May be fixed by #16065
Open

Display Script Results Instead of Job Logs #15983

bitcollector1 opened this issue May 7, 2024 · 3 comments · May be fixed by #16065
Assignees
@abhi1693
Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@bitcollector1
Copy link

bitcollector1 commented May 7, 2024 •
edited

NetBox version

v4.0.0

Feature type

Restore functionality back to the way it was prior to NetBox 4.0; so you can get a link back to the results, from the list of jobs.

Proposed functionality

From the list of completed jobs, provide link to the script "results" page instead of the jobs "logs" page.

Screenshot 2024-05-06 at 18 09 14

Script Results: (right after the script runs)
Screenshot 2024-05-06 at 18 10 51

Job Log: (Prior to NetBox 4.0 clicking on the "Name" would bring you to the results page. Now both "ID" and "Name" bring you to log page.
Screenshot 2024-05-06 at 18 12 57

Use case

Restore functionality back to the way it was prior to NetBox 4.0; so you can get a link back to the results.

Change this link:
/core/jobs/41699/

to this:
/extras/scripts/results/41699/

It's much easier to read the results with all the formatting and color coding.

Database changes

No response

External dependencies

No response
@bitcollector1 bitcollector1 added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels May 7, 2024
@arthanson arthanson removed their assignment May 7, 2024
@arthanson arthanson added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: needs triage This issue is awaiting triage by a maintainer labels May 7, 2024
@bitcollector1 bitcollector1 changed the title Display Job Results Instead of Logs Display Script Results Instead of Job Logs May 8, 2024
@abhi1693 abhi1693 self-assigned this May 9, 2024
@abhi1693 abhi1693 added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels May 9, 2024
@bitcollector1
Copy link
Author

Thanks for taking this up @abhi1693

abhi1693 added a commit that referenced this issue May 9, 2024
@abhi1693
adds extra column for result on the script job table #15983
6f3dfba
@abhi1693 abhi1693 linked a pull request May 9, 2024 that will close this issue
Open
@bitcollector1
Copy link
Author

bitcollector1 commented May 9, 2024 •
edited

Just wanted to confirm that this adds a new column for the "results" to the main jobs page.
/core/jobs/

I'm trying to follow along and it looks like the results are only showing up here:
/extras/scripts/ID/jobs/

I use the main jobs page the most to navigate all the various jobs and to view the results.

looks like there are a couple of jobs tables and it took me a minute to figure out why I was not seeing the changes when I implemented the code proposed.

@bitcollector1 bitcollector1 mentioned this issue May 10, 2024
Closed
abhi1693 added a commit that referenced this issue May 14, 2024
@abhi1693
change completed format to iso #15983
3c108e2
@jeremystretch
Copy link
Member

@bitcollector1 we can't add a "result" column to the generic jobs list as not all jobs reference a result (those are only for scripts).

@jeremystretch jeremystretch added the complexity: low Requires minimal effort to implement label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhi1693 abhi1693

Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds extra column for result on the script job table netbox-community/netbox
4 participants
@arthanson @abhi1693 @jeremystretch @bitcollector1