Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds extra column for result on the script job table #16065

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

abhi1693
Copy link
Member

@abhi1693 abhi1693 commented May 9, 2024

Fixes: #15983

Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abhi1693! Just a couple minor nits.

netbox/extras/views.py Outdated Show resolved Hide resolved
netbox/extras/views.py Outdated Show resolved Hide resolved
@bitcollector1
Copy link

can we add this same info to the core jobs table? That is the page I use the most to check the status of all my various jobs.

@abhi1693
Copy link
Member Author

can we add this same info to the core jobs table

It's out of scope. Results column only makes sense for scripts and jobs table can have other types in it

@jeremystretch
Copy link
Member

Rather than adding another column to the table, it might make more sense to override the "completed" column so that it links to the script result. We could do this in a generic way so that the "completed" column in any jobs table links to the relevant record where applicable.

@bitcollector1
Copy link

Rather than adding another column to the table, it might make more sense to override the "completed" column so that it links to the script result. We could do this in a generic way so that the "completed" column in any jobs table links to the relevant record where applicable.

Thanks Jeremy,

All I'm looking for us parity with 3.7, where you can get to the results from the main page. Appreciate the support and excellent work on a great product.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Script Results Instead of Job Logs
3 participants