Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15153 customize styling browseable rest api #15474

Closed
wants to merge 4 commits into from

Conversation

arthanson
Copy link
Collaborator

@arthanson arthanson commented Mar 19, 2024

Fixes: #15153

Limits on what can be changed without copying and modifying the base template into api.html, but made tweaks to bring it more in-line with app. Just kept inline css as fairly minor changes needed and IMHO not worth tooling for separate css file.

Monosnap Circuits | NetBox REST API 2024-04-01 09-35-12

@arthanson arthanson marked this pull request as ready for review March 19, 2024 14:42
@jeremystretch jeremystretch added this to the v4.0 milestone Mar 19, 2024
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good start, but I see a few issues:

  1. The navbar is not aligned properly
  2. No visual contrast between the navbar and page content
  3. Too much white space

rest_web_ui

netbox/templates/rest_framework/api.html Outdated Show resolved Hide resolved
@arthanson
Copy link
Collaborator Author

Changed to dark header and adjusted spacing / alignment of items

@jeremystretch jeremystretch added the beta Concerns a bug/feature in a beta release label Apr 17, 2024
@jeremystretch jeremystretch removed this from the v4.0 milestone Apr 17, 2024
@jeremystretch jeremystretch removed the beta Concerns a bug/feature in a beta release label May 6, 2024
@jeremystretch
Copy link
Member

We're going to punt on this one for now and revisit once we've spent more time improving the overall UI design.

@jeremystretch jeremystretch deleted the 15153-rest-styling branch May 17, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants