Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue_13422: Ignore MPTT fields in serialisation if being used by staged changes #15830

Closed
wants to merge 3 commits into from

Conversation

minitriga
Copy link
Contributor

@minitriga minitriga commented Apr 24, 2024

Fixes: #13422

Implement a check to disable the removal of MPTT fields during object serialisation.

Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further action is taken.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label May 21, 2024
@arthanson
Copy link
Collaborator

@minitriga can you please fix the merge conflicts

@jeremystretch
Copy link
Member

@minitriga thanks for working on this. I think the MPTT-specific concerns you raised in #13422 are symptomatic of a moderately larger issue, which is the incomplete serialization of object data. I've opened #16290 to resolve this in a more general manner, and designated it as blocking for #13422.

I'm going to work on a PR for #16290, which will effectively incorporate your changes to serialize_object() as well as some additional modifications. I'm going to close this PR as it should no longer be needed, but please do take a look at the PR for #16290 once it's available for review and let me know what you think. Thanks again!

@jeremystretch jeremystretch removed the pending closure Requires immediate attention to avoid being closed for inactivity label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Staged Changes: InventoryItem Fails Sync
3 participants