Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 15348 - Quick Access Saved Filters #15862

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

Julio-Oliveira-Encora
Copy link
Contributor

Feature: #15348

A dropdown was added to list and apply the saved filters to the current view.

@jeremystretch jeremystretch added beta Concerns a bug/feature in a beta release and removed beta Concerns a bug/feature in a beta release labels Apr 29, 2024
@jeremystretch jeremystretch changed the base branch from feature to develop May 20, 2024 12:58
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although functional, displaying the active saved filters in both the original tag form and in the selector widget may be confusing to the user. IMO we should display applied filters only in the selector widget, and show only individual filter values as removable colored tags.

screenshot

netbox/templates/inc/table_controls_htmx.html Outdated Show resolved Hide resolved
netbox/project-static/src/savedFiltersSelect.ts Outdated Show resolved Hide resolved
netbox/project-static/src/savedFiltersSelect.ts Outdated Show resolved Hide resolved
netbox/project-static/src/savedFiltersSelect.ts Outdated Show resolved Hide resolved
@arthanson
Copy link
Collaborator

@Julio-Oliveira-Encora here are the changes after discussion on this:

  • Remove the blue chits for the saved filters only, so normal filters will still show there (The functionality for saving your filters and such should remain). So the selected saved filters will only show in the save filters dropdown.
  • We don't need to change the saved filters to use a placeholder, having the label there is fine.
  • Make the vertical height of the dropdown match the Quick Search so at start they aren't different sizes. You can adjust the text height and padding of the Saved filters, you may also need to tweak the quick search if needed. Note: If you select many saved filters it will wrap and grow the select box, this is fine - we just care about the initial page look when you have no filters (or one filter) selected.

@Julio-Oliveira-Encora
Copy link
Contributor Author

@arthanson I changed the CSS for quick search, because I did get to change the CSS for Dropdown. Please, check them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants