Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docusaurus.config.js for GA4 #179

Merged
merged 6 commits into from Apr 19, 2023
Merged

Update docusaurus.config.js for GA4 #179

merged 6 commits into from Apr 19, 2023

Conversation

andrewm4894
Copy link
Contributor

will need to wait a little until v2.4 of docusaurus to merge this facebook/docusaurus#7221 (comment)

@netlify
Copy link

netlify bot commented Feb 7, 2023

Deploy Preview for netdata-blog ready!

Name Link
🔨 Latest commit 886e998
🔍 Latest deploy log https://app.netlify.com/sites/netdata-blog/deploys/643ff60fb957c700088ef198
😎 Deploy Preview https://deploy-preview-179--netdata-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@andrewm4894 andrewm4894 changed the title Update docusaurus.config.js Update docusaurus.config.js for GA4 Feb 7, 2023
@andrewm4894 andrewm4894 marked this pull request as draft February 7, 2023 14:10
@andrewm4894 andrewm4894 marked this pull request as ready for review March 23, 2023 22:19
@andrewm4894 andrewm4894 marked this pull request as draft March 23, 2023 22:23
@andrewm4894 andrewm4894 marked this pull request as ready for review March 23, 2023 22:34
@aabedraba
Copy link

this should be ready to merge https://github.com/facebook/docusaurus/releases/tag/v2.4.0

@andrewm4894
Copy link
Contributor Author

hmm im still getting

[ERROR] ValidationError: "trackingID" must be a string

@andrewm4894
Copy link
Contributor Author

oh - looks like should use this instead: https://docusaurus.io/docs/api/plugins/@docusaurus/plugin-google-gtag

@andrewm4894 andrewm4894 merged commit e8c6bbe into master Apr 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants