refactor: cleanup buildbot_build_go_functions, zisi_parse_isc and buildbot_nft_transpile_esm` feature flags
#4325
Conversation
danez
added
the
type: chore
|
After updating to zisi 5.11 with FF When this FF is now finally turned on for the tests (because it is removed), zisi is using the One example: import mathAvg from 'math-avg-mispelled'
export default () => mathAvg([])Previously (with Is this expected? cc @Skn0tt @eduardoboucas |
|
Hmm, we've been using NFT for ESM functions for a while now, and maybe we just didn't update the Netlify Build tests accordingly at the time. I think this is okay. |
…ldbot_nft_transpile_esm` ff All 3 are now always on fix(deps): update @netlify/zip-it-and-ship-it to 5.11.0 chore: fix tests
| } | ||
|
|
||
| const PACKAGE_JSON_ORIGINAL_MESSAGE = 'is invalid JSON' | ||
| const PACKAGE_JSON_ORIGINAL_MESSAGES = ['is invalid JSON', 'in JSON at position'] |
There was a problem hiding this comment.
Hmm in JSON at position feels a bit too broad, but I guess there's no better way to catch there errors?
There was a problem hiding this comment.
Yeah i tried to match as a much as possible, but there is not much. The whole error is SyntaxError: Unexpected token { in JSON at position 1
All 3 ff are now always on
Requires netlify/zip-it-and-ship-it#1113