Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mode property to edge functions config #4655

Merged
merged 2 commits into from
Oct 26, 2022
Merged

feat: add mode property to edge functions config #4655

merged 2 commits into from
Oct 26, 2022

Conversation

eduardoboucas
Copy link
Member

Summary

Allows a mode property in edge functions configuration objects, complementing netlify/edge-bundler#165.

@eduardoboucas eduardoboucas added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Oct 26, 2022
@github-actions
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@eduardoboucas eduardoboucas requested a review from a team October 26, 2022 14:45
jackiewmacharia
jackiewmacharia approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@jackiewmacharia jackiewmacharia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mode property is optional, right? If so, this looks good.

@eduardoboucas
Copy link
Member Author

The mode property is optional, right? If so, this looks good.

It is!

@eduardoboucas eduardoboucas merged commit c8078af into main Oct 26, 2022
@eduardoboucas eduardoboucas deleted the feat/edge-functions-mode branch October 26, 2022 15:06
@netlify-jenkins netlify-jenkins mentioned this pull request Oct 26, 2022
Merged
JGAntunes pushed a commit that referenced this pull request Oct 31, 2022
@eduardoboucas @JGAntunes
feat: add mode property to edge functions config (#4655)
22f6bd1 
* feat: add `mode` property to edge functions config

* chore: fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackiewmacharia jackiewmacharia jackiewmacharia approved these changes

Assignees
No one assigned
Labels
Adds or modifies js files type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eduardoboucas @jackiewmacharia