Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add test for generator field and remove internalSrcFolder usage #4857

Merged

Conversation

khendrikse
Copy link
Contributor

@khendrikse khendrikse commented Feb 9, 2023

πŸŽ‰ Thanks for submitting a pull request! πŸŽ‰

Summary

Connected to:


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)
cute dog flying through a spacetime vortex

@khendrikse khendrikse self-assigned this Feb 9, 2023
@khendrikse khendrikse added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Feb 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@khendrikse khendrikse force-pushed the feat-350/remove-internalSrcFolder-and-add-generator-logic branch from 819c478 to 17cfea6 Compare February 9, 2023 08:49
@khendrikse khendrikse force-pushed the feat-350/remove-internalSrcFolder-and-add-generator-logic branch from 9c8b9f3 to e9aa9f5 Compare February 16, 2023 14:32
@khendrikse khendrikse marked this pull request as ready for review February 17, 2023 09:27
@khendrikse khendrikse requested a review from a team February 17, 2023 09:27
@khendrikse khendrikse changed the title test: add test and remove internalSrcFolder usage chore: add test for generator fieldand remove internalSrcFolder usage Feb 17, 2023
@khendrikse khendrikse changed the title chore: add test for generator fieldand remove internalSrcFolder usage fix: add test for generator fieldand remove internalSrcFolder usage Feb 17, 2023
@khendrikse khendrikse changed the title fix: add test for generator fieldand remove internalSrcFolder usage fix: add test for generator field and remove internalSrcFolder usage Feb 17, 2023
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question about a test, but LGTM otherwise.


test.serial('zip-it-and-ship-it runs without error when loading json config files', async (t) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing this test? I thought this was testing the deploy configuration API?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the same test a part of another test I wrote :) so now we have one test with both a snapshot and different field checks :)

@khendrikse khendrikse merged commit f1a0a5b into main Feb 17, 2023
@khendrikse khendrikse deleted the feat-350/remove-internalSrcFolder-and-add-generator-logic branch February 17, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Adds or modifies js files type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants