-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add test for generator field and remove internalSrcFolder usage #4857
fix: add test for generator field and remove internalSrcFolder usage #4857
Conversation
This pull request adds or modifies JavaScript ( |
819c478
to
17cfea6
Compare
9c8b9f3
to
e9aa9f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a question about a test, but LGTM otherwise.
|
||
test.serial('zip-it-and-ship-it runs without error when loading json config files', async (t) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you removing this test? I thought this was testing the deploy configuration API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the same test a part of another test I wrote :) so now we have one test with both a snapshot and different field checks :)
π Thanks for submitting a pull request! π
Summary
Connected to:
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire π₯ (e.g. incident related), you can skip this step.
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)