chore: migrate affected tests to esm #4158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasholzer
added
the
type: chore
lukasholzer
commented
Jan 31, 2022
| @@ -73,7 +73,7 @@ | |||
| "postinstall": "node ./scripts/postinstall.js" | |||
| }, | |||
| "config": { | |||
| "eslint": "--ignore-path .gitignore --cache --format=codeframe --max-warnings=0 \"{src,tools,scripts,site,tests,.github}/**/*.{mjs,cjs,js,md,html}\" \"*.{mjs,cjs,js,md,html}\" \".*.{mjs,cjs,js,md,html}\"", | |||
| "eslint": "--ignore-path .gitignore --cache --format=codeframe --max-warnings=0 \"{src,scripts,site,tests,.github}/**/*.{mjs,cjs,js,md,html}\" \"*.{mjs,cjs,js,md,html}\" \".*.{mjs,cjs,js,md,html}\"", | |||
There was a problem hiding this comment.
needed to exclude tools from eslint as it hangs up on one file:
npx eslint ./tools/project-graph/file-visitor.mjs does not work cc @ehmicky maybe you have a clou for me it seems that some lint rules collide here
There was a problem hiding this comment.
This seems to be a problem with eslint-plugin-import running very slowly when the file being linted has an import ts from 'typescript' statement. This bug report might be the same problem: import-js/eslint-plugin-import#2340
The following seems to fix the problem: changing:
import ts from 'typescript'To:
const { default: ts } = await import(`${'typescript'}`)There was a problem hiding this comment.
@ehmicky yea you are right it passed locally after 13min 🤯 nevertheless I think we should not write our code different because a lint rule is not playing well. I would rather opt then for disabling this lint rule. IMO
📊 Benchmark resultsComparing with 3dd9f74 Package size: 362 MB⬇️ 0.00% decrease vs. 3dd9f74 Legend
|
erezrokah
force-pushed
the
chore/esm-migration-affected-test-runner
branch
from
aa12c1e
to
6cf8b6b
Compare
erezrokah
approved these changes
Feb 4, 2022
erezrokah
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
part of the partial esm migration
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)