-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly watch function files specified in the config option included_files
#4619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with 2a6d9f3 Package size: 294 MB⬇️ 0.00% decrease vs. 2a6d9f3
Legend
|
danez
commented
May 20, 2022
danez
changed the title
fix: correctly watch function files specified in the config option
(WIP) fix: correctly watch function files specified in the config option May 25, 2022
included_files
included_files
danez
force-pushed
the
dt/4454/watchIncludedFilesFromConfig
branch
from
May 30, 2022 17:50
eb3f87d
to
fc89bb7
Compare
danez
changed the title
(WIP) fix: correctly watch function files specified in the config option
fix: correctly watch function files specified in the config option Jun 7, 2022
included_files
included_files
…ncluded_files` Adds the files/globs from the `included_files` config option to the watcher. The resolved paths are returned by zip-it-and-ship-it.
danez
force-pushed
the
dt/4454/watchIncludedFilesFromConfig
branch
from
June 7, 2022 08:59
8154ec4
to
3e59113
Compare
eduardoboucas
previously approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! ✨
eduardoboucas
previously approved these changes
Jun 7, 2022
eduardoboucas
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's such a pain that we have to use timeouts to make these tests work. 😢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: functions
automerge
Add to Kodiak auto merge queue
type: bug
code to address defects in shipped code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4454
Adds the files/globs from the
included_files
config option to the watcher.This requires a new version of zisi with netlify/zip-it-and-ship-it#1098 , which is not released yet.