fix: order of commits in PR comment #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
force-pushed
the
fix/danez/order-of-commits
branch
from
46cc66d
to
31dbfa0
Compare
|
I changed the workflow. As this is github action that runs with a specific runtime (node16 now), there is no need to test other nodejs versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #92
The issue was not that the comparison was wrong, but the order in the graph and the list was wrong.
The easiest to see this right now is in this PR netlify/zip-it-and-ship-it#1134 (comment) Underneath the graph open the legend and hover the commit has. T-15 is the newest commit, T-1 the oldest