Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for post-cache routes #165

Merged
merged 3 commits into from Oct 20, 2022
Merged

Conversation

eduardoboucas
Copy link
Member

Which problem is this pull request solving?

Looks for a mode property in a function declaration (either in the TOML or in-source) and if its value is after_cache, the route is added to post_cache_routes instead of routes in the manifest file. This makes the function run after the cache.

List other issues or pull requests related to this problem

Internal: https://github.com/netlify/pod-compute/issues/208

@eduardoboucas eduardoboucas added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Oct 19, 2022
@eduardoboucas eduardoboucas requested a review from a team October 19, 2022 09:24
EwanValentine
EwanValentine previously approved these changes Oct 19, 2022
Copy link
Contributor

@EwanValentine EwanValentine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

khendrikse
khendrikse previously approved these changes Oct 19, 2022
@eduardoboucas
Copy link
Member Author

After looking at existing configuration properties in https://docs.netlify.com/configure-builds/file-based-configuration/, I feel that using kebab case in the mode values is more appropriate than snake case, so I've changed that in fdc4043.

Can I get another ✅ , please?

@eduardoboucas eduardoboucas merged commit c7e530b into main Oct 20, 2022
@eduardoboucas eduardoboucas deleted the feat/post-cache-routes branch October 20, 2022 08:56
@ascorbic
Copy link
Member

😍

Skn0tt pushed a commit to netlify/build that referenced this pull request Apr 23, 2024
* feat: add support for post-cache routes

* refactor: rename `mode` values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants