Skip to content

Changes Sign Up form type to name instead of email #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

tzmanics
Copy link
Contributor

@tzmanics tzmanics commented Jul 5, 2020

Form type was set to email so the form placeholder asked for email when it needed name.

Before:
Screen Shot 2020-07-05 at 4 38 05 PM

After:

Screen Shot 2020-07-05 at 4 53 46 PM

closes #285

@tzmanics tzmanics self-assigned this Jul 5, 2020
@tzmanics tzmanics added the type: bug code to address defects in shipped code label Jul 5, 2020
@netlify
Copy link

netlify bot commented Jul 5, 2020

Deploy Success!

Built with commit ce5b1b6

https://deploy-preview-286--identity.netlify.app

@tzmanics tzmanics changed the title Changes Sign Up form type to name instead of email [DRAFT] Changes Sign Up form type to name instead of email Jul 5, 2020
@tzmanics tzmanics requested review from cassidoo and jlengstorf July 5, 2020 20:55
Copy link
Contributor

@cassidoo cassidoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, good catch Tara!

@jlengstorf jlengstorf merged commit 3646afe into master Jul 6, 2020
@jlengstorf jlengstorf deleted the tzm/285/signUpFormWidgetAsksForEmail branch July 6, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sign up form widget asks for email instead of name
3 participants