This repository has been archived by the owner on May 2, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this pull request solving?
Edge Handlers will provide browser apis if they can. We should choose the
browser
entrypoint of any packages if it is provided.Some modules are built for node, but can run fine on our runtime, if you provide shims.
Describe the solution you've chosen
Enable
browser: true
in the resolve module.Set
preferBuiltins: false
so people can install their own shims if they want.Add the
node-globals
andnode-builtins
rollup plugins.Describe alternatives you've considered
We could require people to install shims themselves.
Checklist