feat: Pass additional functions attributes to API from manifest #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for open-api ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
the
type: feature
jackiewmacharia
changed the title
It will be easier debugging issues on checks failing on PRs by running triggering them on the default branch, to rule out if the problem is only in the PR or also on the default branch. Documentation: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch Part of #395
Add documentation for:
* `GET /{account_slug}/members/{member_id}`
* `PUT /{account_slug}/members/{member_id}`
* `DELETE /{account_slug}/members/{member_id}`
Update documentation for:
* `POST /{account_slug}/members` - params should be in request body, not query params.
* I needed to `$ go get -u golang.org/x/sys` as `$ make generate` on
macOS 12.6 with Go 1.19.3 (Homebrew) othwerwise failed with
"go:linkname must refer to declared function or variable".
The suggested solution to update sys comes from
https://stackoverflow.com/a/71508032/265508
Fixes #395
Co-authored-by: Nicola Aitken <nicola.aitken@netlify.com>
|
Note: I did a rebase on master, as the PR was a bit older, but it added a bunch of changes that are not relevant to this PR, so I reverted those commits. I'm a bit confused why me rebasing on the master branch added new changes to this branch that will be merged into master. |
5 tasks
|
Close because this one has replaced it: #418 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Karin:
This is work that is done for https://github.com/netlify/pod-compute/issues/156
In work done inside netlify/zip-it-and-ship-it#1221 we are now generating an extra field inside of the functions manifest
displayNameWe want to make these available in the API as well. That's what this PR is all about!