fix: use unixify for checkIsInternalFunction, config, bundler, module…

… and resolve

src/runtimes/node/bundlers/esbuild/bundler.ts

@@ -2,6 +2,7 @@ import { basename, dirname, extname, resolve, join } from 'path'
 
 import { build, Metafile } from '@netlify/esbuild'
 import { tmpName } from 'tmp-promise'
+import unixify from 'unixify'
 
 import type { FunctionConfig } from '../../../../config.js'
 import { FeatureFlags } from '../../../../feature_flags.js'
@@ -89,7 +90,7 @@ export const bundleJsFile = async function ({
   // esbuild will format `sources` relative to the sourcemap file, which lives
   // in `destFolder`. We use `sourceRoot` to establish that relation. They are
   // URLs, not paths, so even on Windows they should use forward slashes.
-  const sourceRoot = targetDirectory.replace(/\\/g, '/')
+  const sourceRoot = unixify(targetDirectory)
 
   // Configuring the output format of esbuild. The `includedFiles` array we get
   // here contains additional paths to include with the bundle, like the path

src/runtimes/node/bundlers/zisi/resolve.ts

@@ -6,14 +6,13 @@ import { pathExists } from 'path-exists'
 // @ts-expect-error types are wrong
 import { async as asyncResolve } from 'resolve'
 import semver from 'semver'
+import unixify from 'unixify'
 
 // The types do not include the mjs api of resolve
 const resolveLib = asyncResolve as typeof import('resolve')
 
 const require = createRequire(import.meta.url)
 
-const BACKSLASH_REGEXP = /\\/g
-
 // Find the path to a module's `package.json`
 // We need to use `resolve` instead of `require.resolve()` because:
 //  - it is async
@@ -107,7 +106,7 @@ const resolvePackageFallback = async function (moduleName: string, baseDirs: str
 const isPackageDir = async function (moduleName: string, dir: string) {
   // Need to use `endsWith()` to take into account `@scope/package`.
   // Backslashes need to be converted for Windows.
-  if (!dir.replace(BACKSLASH_REGEXP, '/').endsWith(moduleName) || !(await pathExists(`${dir}/package.json`))) {
+  if (!unixify(dir).endsWith(moduleName) || !(await pathExists(`${dir}/package.json`))) {
     return
   }
 

src/runtimes/node/utils/module.ts

@@ -1,11 +1,10 @@
 import requirePackageName from 'require-package-name'
-
-// Windows path normalization
-const BACKSLASH_REGEXP = /\\/g
+import unixify from 'unixify'
 
 // When doing require("moduleName/file/path"), only keep `moduleName`
 export const getModuleName = function (dependency: string): string {
-  const dependencyA = dependency.replace(BACKSLASH_REGEXP, '/')
+  // Windows path normalization
+  const dependencyA = unixify(dependency)
   const moduleName = requirePackageName(dependencyA)
 
   return moduleName

src/utils/check_is_internal_function.ts

@@ -1,8 +1,5 @@
-import { FUNCTIONS_INTERNAL_DIR } from '../runtimes/constants.js'
+import unixify from 'unixify'
 
-export const checkIsInternalFunction = (srcDir = '') => {
-  const BACKSLASH_REGEXP = /\\/g
+import { FUNCTIONS_INTERNAL_DIR } from '../runtimes/constants.js'
 
-  // Backslashes need to be converted for Windows.
-  return srcDir?.replace(BACKSLASH_REGEXP, '/').includes(FUNCTIONS_INTERNAL_DIR)
-}
+export const checkIsInternalFunction = (srcDir = '') => unixify(srcDir)?.includes(FUNCTIONS_INTERNAL_DIR)