chore: use BINARY_PATH constant in tests (#979)

netlify · Feb 8, 2022 · fe96bc0 · fe96bc0 · github-actions · Feb 8, 2022
1 parent 194a103
commit fe96bc0
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/tests/bin.js b/tests/bin.js
@@ -6,9 +6,7 @@ const { tmpName } = require('tmp-promise')
 
 const { version } = require('../package.json')
 
-const { FIXTURES_DIR } = require('./helpers/main')
-
-const BINARY_PATH = join(__dirname, '..', 'dist', 'bin.js')
+const { FIXTURES_DIR, BINARY_PATH } = require('./helpers/main')
 
 const exec = (args, options) => execa('node', [BINARY_PATH, ...args], options)
 

diff --git a/tests/helpers/main.js b/tests/helpers/main.js
@@ -9,6 +9,7 @@ const { zipFunctions } = require('../..')
 const { listImports } = require('../../dist/runtimes/node/bundlers/zisi/list_imports')
 
 const FIXTURES_DIR = join(__dirname, '..', 'fixtures')
+const BINARY_PATH = join(__dirname, '..', '..', 'dist', 'bin.js')
 
 const zipNode = async function (t, fixture, { length, fixtureDir, opts } = {}) {
   const { files, tmpDir } = await zipFixture(t, fixture, {
@@ -113,4 +114,5 @@ module.exports = {
   unzipFiles,
   zipCheckFunctions,
   FIXTURES_DIR,
+  BINARY_PATH,
 }
diff --git a/tests/main.js b/tests/main.js
@@ -32,7 +32,15 @@ const { zipFunction, listFunctions, listFunctionsFiles, listFunction } = require
 const { ESBUILD_LOG_LIMIT } = require('../dist/runtimes/node/bundlers/esbuild/bundler')
 const { detectEsModule } = require('../dist/runtimes/node/utils/detect_es_module')
 
-const { getRequires, zipNode, zipFixture, unzipFiles, zipCheckFunctions, FIXTURES_DIR } = require('./helpers/main')
+const {
+  getRequires,
+  zipNode,
+  zipFixture,
+  unzipFiles,
+  zipCheckFunctions,
+  FIXTURES_DIR,
+  BINARY_PATH,
+} = require('./helpers/main')
 const { computeSha1 } = require('./helpers/sha')
 const { makeTestMany } = require('./helpers/test_many')
 
@@ -1509,11 +1517,10 @@ testMany(
 
 test('Limits the amount of log lines produced by esbuild', async (t) => {
   const { path: tmpDir } = await getTmpDir({ prefix: 'zip-it-test' })
-  const binaryPath = resolve(__dirname, '../dist/bin.js')
   const fixturePath = join(FIXTURES_DIR, 'esbuild-log-limit')
 
   try {
-    await execa('node', [binaryPath, fixturePath, tmpDir, `--config.*.nodeBundler=esbuild`])
+    await execa('node', [BINARY_PATH, fixturePath, tmpDir, `--config.*.nodeBundler=esbuild`])
 
     t.fail('Bundling should have thrown')
   } catch (error) {