Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use safe version of getPackageJson when transpiling ESM #1008

Merged
merged 2 commits into from Feb 8, 2022
Merged

fix: use safe version of getPackageJson when transpiling ESM #1008

merged 2 commits into from Feb 8, 2022

Conversation

eduardoboucas
Copy link
Member

Summary

Use getPackageJsonIfAvailable instead of getPackageJson, to avoid throwing an error when transpiling ESM in NFT.

@eduardoboucas eduardoboucas added the type: bug code to address defects in shipped code label Feb 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

⏱ Benchmark results

largeDepsEsbuild: 8.5s

^   8.5s  
│   ┌──┐  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
└───┴──┴──>
     T
Legend
  • T (current commit): 8.5s

largeDepsNft: 38.2s

^  38.2s  
│   ┌──┐  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
└───┴──┴──>
     T
Legend
  • T (current commit): 38.2s

@kodiakhq kodiakhq bot merged commit 8c4b234 into main Feb 8, 2022
@kodiakhq kodiakhq bot deleted the fix/safe-getpackagejson branch February 8, 2022 13:29
@token-generator-app token-generator-app bot mentioned this pull request Feb 8, 2022
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erezrokah erezrokah erezrokah approved these changes

Assignees
No one assigned
Labels
automerge type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eduardoboucas @erezrokah