Skip to content
This repository was archived by the owner on May 22, 2024. It is now read-only.

fix: use safe version of getPackageJson when transpiling ESM #1008

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

eduardoboucas
Copy link
Member

Summary

Use getPackageJsonIfAvailable instead of getPackageJson, to avoid throwing an error when transpiling ESM in NFT.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@eduardoboucas eduardoboucas added the type: bug code to address defects in shipped code label Feb 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

⏱ Benchmark results

largeDepsEsbuild: 8.5s

^   8.5s  
│   ┌──┐  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
└───┴──┴──>
     T    
Legend
  • T (current commit): 8.5s

largeDepsNft: 38.2s

^  38.2s  
│   ┌──┐  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
└───┴──┴──>
     T    
Legend
  • T (current commit): 38.2s

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@kodiakhq kodiakhq bot merged commit 8c4b234 into main Feb 8, 2022
@kodiakhq kodiakhq bot deleted the fix/safe-getpackagejson branch February 8, 2022 13:29
Skn0tt pushed a commit to netlify/build that referenced this pull request May 21, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…fy/zip-it-and-ship-it#1008)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants