New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove feature flag buildGoSource and zisi_detect_esm #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
added
the
type: chore
work needed to keep the product and development running smoothly
label
Jun 15, 2022
⏱ Benchmark resultsComparing with 6284742 largeDepsEsbuild: 6.6s⬆️ 5.10% increase vs. 6284742
Legend
largeDepsNft: 31s⬇️ 2.31% decrease vs. 6284742
Legend
largeDepsZisi: 46.4s⬇️ 0.77% decrease vs. 6284742
Legend
|
Both are on by default now
danez
changed the title
refactor: cleanup resolved feature flags
refactor: remove feature flag buildGoSource and zisi_detect_esm
Jun 15, 2022
danez
commented
Jun 15, 2022
eduardoboucas
approved these changes
Jun 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🧹
@danez you might want to rename this to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up 3 feature flags that are already resolved and always on.