Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove feature flag buildGoSource and zisi_detect_esm #1113

Merged
merged 1 commit into from Jun 15, 2022

Conversation

danez
Copy link
Contributor

@danez danez commented Jun 15, 2022

This cleans up 3 feature flags that are already resolved and always on.

5f5a5f37e6ff30001d4e8163

@danez danez added the type: chore work needed to keep the product and development running smoothly label Jun 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2022

⏱ Benchmark results

Comparing with 6284742

largeDepsEsbuild: 6.6s

⬆️ 5.10% increase vs. 6284742

^                   8.2s                                    8.3s                                          
│           7.7s    ┌──┐                                    ┌──┐            7.7s                          
│           ┌──┐    |  |                                    |  |            ┌──┐                          
│           |  |    |  |                                    |  |            |  |                          
│ ──6.5s────┼──┼────┼──┼────────────────────────────────────┼──┼────6.4s────┼──┼────────────6.6s────6.6s──
│   ┌──┐    |  |    |  |    6.1s    6.3s    6.3s    6.1s    |  |    ┌──┐    |  |    6.3s    ┌──┐    ┌──┐  
│   |  |    |  |    |  |    ┌──┐    ┌──┐    ┌──┐    ┌──┐    |  |    |  |    |  |    ┌──┐    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

largeDepsNft: 31s

⬇️ 2.31% decrease vs. 6284742

^                                                          39.9s           40.5s                          
│                  39.1s                                    ┌──┐            ┌──┐                          
│          35.9s    ┌──┐                                    |  |            |  |                          
│           ┌──┐    |  |                                    |  |            |  |                          
│           |  |    |  |                                    |  |            |  |                          
│ ─30.4s────┼──┼────┼──┼───────────30.5s────────────────────┼──┼────────────┼──┼───────────30.7s────31s───
│   ┌──┐    |  |    |  |            ┌──┐    28s    28.1s    |  |    28s     |  |   29.1s    ┌──┐    ┌──┐  
│   |  |    |  |    |  |   27.2s    |  |    ┌──┐    ┌──┐    |  |    ┌──┐    |  |    ┌──┐    |  |    |▒▒|  
│   |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

largeDepsZisi: 46.4s

⬇️ 0.77% decrease vs. 6284742

^                  57.6s                                   57.6s           58.3s                          
│                   ┌──┐                                    ┌──┐            ┌──┐                          
│                   |  |                                    |  |            |  |                          
│                   |  |                                    |  |            |  |                          
│ ─46.3s────────────┼──┼───────────46.8s────────────────────┼──┼────────────┼──┼────────────47s────46.4s──
│   ┌──┐            |  |   43.9s    ┌──┐   43.7s   44.4s    |  |   44.1s    |  |   45.1s    ┌──┐    ┌──┐  
│   |  |            |  |    ┌──┐    |  |    ┌──┐    ┌──┐    |  |    ┌──┐    |  |    ┌──┐    |  |    |▒▒|  
│   |  |            |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |            |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |            |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |            |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |            |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |            |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |            |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |            |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |            |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |            |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |            |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |            |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |            |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |            |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    n/a     |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────────────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

@danez danez changed the title refactor: cleanup resolved feature flags refactor: remove feature flag buildGoSource and zisi_detect_esm Jun 15, 2022
@danez danez marked this pull request as ready for review June 15, 2022 14:05
@danez danez requested a review from eduardoboucas June 15, 2022 14:05
tests/main.js Show resolved Hide resolved
@danez danez requested a review from a team June 15, 2022 14:07
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🧹

@eduardoboucas
Copy link
Member

@danez you might want to rename this to use feat:, otherwise it won't generate a release.

@danez danez merged commit 77763f6 into main Jun 15, 2022
@danez danez deleted the ff_cleanup branch June 15, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants