fix: add more error info on missing functions folders #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
commented
Jul 5, 2022
| export const listFunctionsDirectory = async function (srcFolder: string) { | ||
| try { | ||
| const filenames = await fs.readdir(srcFolder) | ||
| const listFunctionsDirectory = async function (srcFolder: string) { |
There was a problem hiding this comment.
I removed the export as it is nowhere used outside this file, and also is not a Public API.
⏱ Benchmark resultsComparing with cd082fc largeDepsEsbuild: 5.7s⬇️ 4.85% decrease vs. cd082fc LegendlargeDepsNft: 28s⬇️ 6.32% decrease vs. cd082fc LegendlargeDepsZisi: 42.9s⬇️ 4.47% decrease vs. cd082fc |
danez
commented
Jul 5, 2022
| return filenames.map((name) => join(srcFolder, name)) | ||
| } catch { | ||
| throw new Error(`Functions folder does not exist: ${srcFolder}`) | ||
| } |
There was a problem hiding this comment.
As we do not export it we do not need to catch anymore, because the error will be matched in the function above.
danez
commented
Jul 5, 2022
| srcFolders.map(async (srcFolder) => { | ||
| try { | ||
| const filenames = await listFunctionsDirectory(srcFolder) | ||
| const filenamesByDirectory = await Promise.allSettled( |
There was a problem hiding this comment.
allSettled is available as of node 12.9.0
danez
force-pushed
the
fix/danez/missing-folder
branch
from
bc5a643
to
ab2ef31
Compare
danez
commented
Jul 18, 2022
src/utils/fs.ts
Outdated
| const validDirectories = filenamesByDirectory | ||
| .map((result) => { | ||
| if (result.status === 'rejected') { | ||
| if (result.reason instanceof Error && (result.reason as NodeJS.ErrnoException).code !== 'ENOENT') { |
There was a problem hiding this comment.
For some reason Error does not contain code, so this is the workaround.
eduardoboucas
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
For https://github.com/netlify/pod-compute/issues/108
Throws underlying errors if the error is not a FileNotFound Error.