fix: annotate ISC errors and split into to separate errors #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱ Benchmark resultsComparing with b0048a4 largeDepsEsbuild: 7.7s⬆️ 4.76% increase vs. b0048a4 LegendlargeDepsNft: 40.5s⬆️ 4.38% increase vs. b0048a4 LegendlargeDepsZisi: 55s⬆️ 1.36% increase vs. b0048a4 |
danez
commented
Jul 14, 2022
| super(message) | ||
|
|
||
| Object.setPrototypeOf(this, new.target.prototype) | ||
| this.name = 'FunctionBundlingUserError' |
There was a problem hiding this comment.
These two lines are necessary because typescript does not support extending builtins completely
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-2.html#support-for-newtarget
danez
commented
Jul 14, 2022
| let scheduledFuncsFound = 0 | ||
| const scheduledFunctionExpected = imports.some(({ imported }) => imported === 'schedule') | ||
| let scheduledFunctionFound = false | ||
| let scheduleFound = false |
There was a problem hiding this comment.
I changed the logic a little because all we care if schedule was imported once, if someone imports multiple times, then that is fine too as long as one of the imports is used and exported.🤷♂️
danez
commented
Jul 18, 2022
| @@ -0,0 +1,70 @@ | |||
| import type { Message } from '@netlify/esbuild' | |||
There was a problem hiding this comment.
I had to extract all the types from index.js into types.js, to avoid a cycle dependency.
…nd-ship-it into fix/danez/error-message
eduardoboucas
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes #1145
Annotates the errors and also splits them into to errors to guide users into the right direction.
For us to review and ship your PR efficiently, please perform the following steps:
This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing
a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)