This repository has been archived by the owner on May 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 35
fix: refactor error annotation, to not loose original error #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the previous approach for example `code` was lost Instead of wrapping the error we now only annotate it
⏱ Benchmark resultsComparing with eb1d3dd largeDepsEsbuild: 7.8s⬇️ 4.14% decrease vs. eb1d3dd
LegendlargeDepsNft: 37.5s⬇️ 9.01% decrease vs. eb1d3dd
LegendlargeDepsZisi: 56.8s⬇️ 0.60% decrease vs. eb1d3dd
|
eduardoboucas
approved these changes
Jul 19, 2022
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
May 21, 2024
…zip-it-and-ship-it#1152) With the previous approach for example `code` was lost Instead of wrapping the error we now only annotate it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the previous approach all custom error properties like for example
code
were lostInstead of wrapping the error we now only add the customErrorInfo and leave it untouched otherwise.
The current version of zisi breaks @netlify/build because it makes some assumptions about errors (message, code, type) that were changed in #1146