feat!: convert to ESM and vitest #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱ Benchmark resultsComparing with dec4d3f largeDepsEsbuild: 5.5s⬇️ 35.31% decrease vs. dec4d3f LegendlargeDepsNft: 29.3s⬇️ 24.58% decrease vs. dec4d3f LegendlargeDepsZisi: 41.2s⬇️ 35.26% decrease vs. dec4d3f |
lukasholzer
approved these changes
Oct 27, 2022
| @@ -17,7 +17,7 @@ jobs: | |||
| with: | |||
| token: ${{ steps.get-token.outputs.token }} | |||
| release-type: node | |||
| package-name: '@netlify/@netlify/zip-it-and-ship-it' | |||
| package-name: '@netlify/zip-it-and-ship-it' | |||
| @@ -19,4 +20,9 @@ const runBenchmarks = async function () { | |||
| console.log(`${largeDepsEsbuild}ms`) | |||
| } | |||
|
|
|||
| runBenchmarks() | |||
| try { | |||
| await runBenchmarks() | |||
There was a problem hiding this comment.
Just as information you could now use the vitest bench benchmarking functionality. Nothing to change here but just as a FYI
There was a problem hiding this comment.
Yeah, I was wondering, but didn't want to add even more changes.
Not super happy with vitest yet, had to do some workarounds, so do not want to buy in yet fully :)
| @@ -8,6 +8,7 @@ import endOfStream from 'end-of-stream' | |||
|
|
|||
| export { Archiver as ZipArchive } from 'archiver' | |||
|
|
|||
| // TODO make enum | |||
danez
commented
Oct 27, 2022
| // @ts-expect-error vitest with esbuild already resolves the default export, whereas Node.js does not | ||
| const resolveDependency: typeof nftResolveDependency.default = nftResolveDependency.default | ||
| ? nftResolveDependency.default | ||
| : nftResolveDependency |
There was a problem hiding this comment.
Reported here: vitest-dev/vitest#2219
danez
commented
Oct 27, 2022
| export const importFunctionFile = async function <T = any>(functionPath: string): Promise<T> { | ||
| // We use relative paths here, because vitest cannot handle absolute paths or urls :( | ||
| // eslint-disable-next-line import/no-dynamic-require | ||
| const result = await import(`/@fs/${functionPath}`) |
There was a problem hiding this comment.
Reported here vitest-dev/vitest#2218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes #749
This converts zisi to pure ESM. It also migrates from ava to vitest.
For us to review and ship your PR efficiently, please perform the following steps:
This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing
a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)