Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use new babel parser #1435

Merged
merged 2 commits into from May 16, 2023
Merged

feat: use new babel parser #1435

merged 2 commits into from May 16, 2023

Conversation

danez
Copy link
Contributor

@danez danez commented May 15, 2023

Summary

Refs #968

This allows us to switch between babel parsers with a feature flag.

@danez danez self-assigned this May 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2023 •
edited

⏱ Benchmark results

Comparing with ffd786d

largeDepsEsbuild: 2s

⬆️ 1.99% increase vs. ffd786d

^   2.9s                  
│   ┌──┐                  
│   |  |                  
│   |  |                  
│   |  |                  
│ ──┼──┼──────────────────
│   |  |     2s      2s   
│   |  |    ┌──┐    ┌──┐  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴──>
    T-2     T-1      T
Legend

largeDepsNft: 6.9s

⬆️ 2.66% increase vs. ffd786d

^  11.4s                  
│   ┌──┐                  
│   |  |                  
│   |  |                  
│   |  |                  
│   |  |                  
│ ──┼──┼──────────────────
│   |  |                  
│   |  |    6.8s    6.9s  
│   |  |    ┌──┐    ┌──┐  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴──>
    T-2     T-1      T
Legend

largeDepsZisi: 13.9s

⬆️ 1.17% increase vs. ffd786d

^  20.8s                  
│   ┌──┐                  
│   |  |                  
│   |  |                  
│   |  |                  
│ ──┼──┼──────────────────
│   |  |                  
│   |  |   13.8s   13.9s  
│   |  |    ┌──┐    ┌──┐  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴──>
    T-2     T-1      T
Legend

@kodiakhq kodiakhq bot requested a review from a team as a code owner May 16, 2023 11:04
@kodiakhq kodiakhq bot merged commit 4962361 into main May 16, 2023
9 checks passed
@kodiakhq kodiakhq bot deleted the parser branch May 16, 2023 11:10
@token-generator-app token-generator-app bot mentioned this pull request May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduardoboucas eduardoboucas eduardoboucas approved these changes

@lukasholzer lukasholzer Awaiting requested review from lukasholzer

Assignees

@danez danez

Labels
automerge Ecosystem: Dev Foundations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danez @eduardoboucas