Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check peerDependenciesMeta for Optional Dependencies #83

Merged
merged 1 commit into from Jan 30, 2020

Conversation

devotox
Copy link
Contributor

@devotox devotox commented Jan 27, 2020

  • Summary

This updates the optional dependencies check to also check peer dependencies meta

The Peer Dependencies Meta field was added to Yarn here:
Yarn#6671

This is used by a number of packages to allow them to be yarn -pnp compatible, most notably Knex.
This feature was added in version 0.20.1

  • Test plan

Unit tests are included but cannot be run as it cannot get to that branch of the code in a similar way as the Ignore missing optional dependencies test.

  • Description for the changelog

Check Peer Dependencies Meta for Optional Dependencies

@devotox devotox requested review from ehmicky and biilmann and removed request for ehmicky January 27, 2020 19:07
@ehmicky
Copy link
Contributor

ehmicky commented Jan 30, 2020

Thanks a lot @devotox for this PR!

@ehmicky ehmicky merged commit 91fa700 into netlify:master Jan 30, 2020
@devotox
Copy link
Contributor Author

devotox commented Jan 31, 2020

@ehmicky when do you think this will be released and be used with Netlify CLI

@ehmicky
Copy link
Contributor

ehmicky commented Feb 6, 2020

@devotox This should be live if you use the Netlify Build beta.

@devotox
Copy link
Contributor Author

devotox commented Mar 2, 2020

@ehmicky I have not been given access to Netlify Build Beta and was wondering how I could use this with Netlify Actions.

Would I need to fork it all?

@ehmicky
Copy link
Contributor

ehmicky commented Mar 2, 2020

@DavidWells Would it be possible to give @devotox access to the Netlify Build beta?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants