Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin @babel/parser to 7.16.8 #966

Merged
merged 1 commit into from Jan 27, 2022
Merged

fix: pin @babel/parser to 7.16.8 #966

merged 1 commit into from Jan 27, 2022

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Jan 27, 2022

Some builds are experiencing a big slowdown when we upgrade @babel/parser from 7.16.8 to 7.16.10 (note: there is no 7.16.9 release).

The only PR introduced by that release is babel/babel#14130, so it appears to have some issues. It could be one of the following bugs, but we are not sure yet: babel/babel#14182, babel/babel#14175

We are certain that the problem comes from this specific package and this specific version. We also know the problem comes from @babel/parser as a direct dependency of @netlify/zip-it-and-ship-it, as opposed to as an indirect dependency through precinct and node-source-walker.

This PR pins the version of @babel/parser until we figure out why this version is creating a problem on our side.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code
    πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re
    fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

@ehmicky ehmicky added the type: bug code to address defects in shipped code label Jan 27, 2022
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants