Request::getBody(), see #57 #58

JanTvrdik · 2015-02-27T13:02:06Z

No description provided.

fprochazka · 2015-02-27T13:09:55Z

src/Http/Request.php

@@ -293,7 +298,17 @@ public function getRemoteHost()
 	 */
 	public function getRawBody()
 	{
-		return $this->rawBodyCallback ? call_user_func($this->rawBodyCallback) : NULL;
+		return $this->rawBodyCallback ? call_user_func($this->rawBodyCallback, $this) : NULL;


IMHO rawbody should return rawbody, not parsed body

? This commit does not change getRawBody() result.

You're using the same callback, that also parses the JSON for application/json, aren't you?

Oh, you've added new parameter, sorry :)

Majkl578 · 2015-02-27T13:43:59Z

Although it's a nice closure magic, I'm afraid it's gonna be slow, it's not even lazy... I mean, those unnecessary body calls could be easily avoided if type check was extracted outside (like addBodyCallback('application/json', $cb)).

JanTvrdik · 2015-02-27T14:07:51Z

@Majkl578 That's how I originally wanted to do it, but then I though that it is not powerful enough. What if you want to make decision based on something different than Content-Type (e.g. HTTP method)? What if you want to handle all something/* types? That being said I like the simple solution addBodyCallback('application/json', $cb) more than the current one.

JanTvrdik · 2015-04-23T16:18:58Z

~~Sidenote: it must somehow workaround the JSON decode DOS vulnerability.~~

JanTvrdik · 2016-06-05T07:15:49Z

I think that this is now ready to merge.

enumag · 2016-06-05T07:20:25Z

src/Http/Request.php

+	 * @throws InvalidRequestBodyException
+	 */
+	public function getBody()
+		{


indentation

enumag · 2016-06-05T07:27:50Z

@JanTvrdik What about the JSON decode DOS vulnerability? I didn't see anything that would solve it in your code (but I might have missed it of course).

JanTvrdik · 2016-06-05T11:31:14Z

@enumag I ignore it the same way everybody in the PHP worlds ignores it. Those few that are concern may replace the body parser for JSON with sth smarter.

JanTvrdik · 2016-06-05T12:39:14Z

BTW: PSR7 calls this method getParsedBody() instead of just getBody(). It is longer but a bit more descriptive.

dg · 2016-06-06T17:16:57Z

src/Http/RequestFactory.php

+			if ($body === NULL) {
+				$contentType = $request->getHeader('Content-Type');
+				foreach ($this->bodyParsers as $parserContentType => $parser) {
+					if (stripos($contentType, $parserContentType) === 0) {


strcasecmp is better

You mean strncasecmp?

Yes. Its PHP shame that there is no startsWith function.

fprochazka reviewed Feb 27, 2015
View reviewed changes

dg force-pushed the master branch from 78a872a to 360dadc Compare June 19, 2015 12:10

dg force-pushed the master branch 7 times, most recently from 1dc599c to f35d20f Compare November 5, 2015 00:41

dg force-pushed the master branch from 805ff25 to dadd667 Compare February 8, 2016 13:29

dg force-pushed the master branch from 51568f8 to 2381182 Compare April 11, 2016 01:45

dg force-pushed the master branch from 19c6fa9 to 28af524 Compare April 21, 2016 11:29

dg force-pushed the master branch from 6286f91 to d523f35 Compare May 9, 2016 12:49

JanTvrdik force-pushed the request_get_body branch 2 times, most recently from f73e5f9 to 48409af Compare June 5, 2016 07:15

JanTvrdik changed the title ~~WIP: Request::getBody(), see #57~~ Request::getBody(), see #57 Jun 5, 2016

JanTvrdik force-pushed the request_get_body branch from 48409af to 48a3e5f Compare June 5, 2016 07:17

enumag reviewed Jun 5, 2016
View reviewed changes

src/Http/Request.php Outdated

* @throws InvalidRequestBodyException

*/

public function getBody()

{

Copy link

Contributor

enumag Jun 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

JanTvrdik force-pushed the request_get_body branch from 48a3e5f to 6363c41 Compare June 5, 2016 07:27

Request: add getBody (interface BC break)

1627f10

JanTvrdik force-pushed the request_get_body branch from 6363c41 to 1627f10 Compare June 5, 2016 12:30

dg reviewed Jun 6, 2016
View reviewed changes

dg force-pushed the master branch 2 times, most recently from 0f24022 to ebdb825 Compare January 15, 2023 17:08

dg force-pushed the master branch 7 times, most recently from 684be2b to 2a0c595 Compare January 24, 2023 19:09

dg force-pushed the master branch from 2a0c595 to 4ca7b03 Compare January 26, 2023 22:47

dg force-pushed the master branch 6 times, most recently from da24b94 to 540335c Compare March 20, 2023 13:43

dg force-pushed the master branch 2 times, most recently from e7c7e2d to bf945f3 Compare August 5, 2023 19:08

dg force-pushed the master branch from a19ca3a to 95b6999 Compare September 16, 2023 09:57

dg force-pushed the master branch 3 times, most recently from 9a14e6e to a20fb8f Compare November 14, 2023 18:31

dg force-pushed the master branch 5 times, most recently from 55488bd to 2042d2e Compare December 11, 2023 13:01

dg force-pushed the master branch from 2042d2e to 3dd9381 Compare January 30, 2024 18:25

dg force-pushed the master branch 2 times, most recently from 4960652 to 5e67add Compare May 2, 2024 10:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Request::getBody(), see #57 #58

Request::getBody(), see #57 #58

JanTvrdik commented Feb 27, 2015

fprochazka Feb 27, 2015

JanTvrdik Feb 27, 2015

fprochazka Feb 27, 2015

fprochazka Feb 27, 2015

Majkl578 commented Feb 27, 2015

JanTvrdik commented Feb 27, 2015

JanTvrdik commented Apr 23, 2015 •

edited

JanTvrdik commented Jun 5, 2016

enumag Jun 5, 2016

enumag commented Jun 5, 2016 •

edited

JanTvrdik commented Jun 5, 2016 •

edited

JanTvrdik commented Jun 5, 2016

dg Jun 6, 2016

JanTvrdik Jun 6, 2016

dg Jun 6, 2016

Request::getBody(), see #57 #58

Are you sure you want to change the base?

Request::getBody(), see #57 #58

Conversation

JanTvrdik commented Feb 27, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Majkl578 commented Feb 27, 2015

JanTvrdik commented Feb 27, 2015

JanTvrdik commented Apr 23, 2015 • edited

JanTvrdik commented Jun 5, 2016

Choose a reason for hiding this comment

enumag commented Jun 5, 2016 • edited

JanTvrdik commented Jun 5, 2016 • edited

JanTvrdik commented Jun 5, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JanTvrdik commented Apr 23, 2015 •

edited

enumag commented Jun 5, 2016 •

edited

JanTvrdik commented Jun 5, 2016 •

edited