Added possibility to store other request then the current one

[enumag]

I'd like to store the request in ErrorPresenter like this:

final class ErrorPresenter extends BasePresenter
{
    public function renderDefault($exception, $request)
    {
        // ...
        $this->storeRequest('+ 10 minutes', $request);
        // ...
    }
}

[Majkl578]

👍 for the feature, but 👎 for implementation as it looks too hacky. storeRequest($request, $expiration) would make much more sense to me, but the method would do a magic.

[enumag]

@Majkl578 Huh? How would you implement it then? I'm actually thinking about hacking it even more so that the first parameter would be optional.

EDIT: Yeah, switching the parameters order probably would be better. (I've thought about that as well actually.)

@dg Which way do you want me to implement it?

[dg]

storeRequest($request, $expiration) is better.

[enumag]

@Majkl578 Is it ok now in your opinion? :-)

[Majkl578]

NULL check is unnecessary.

[enumag]

It is necessary because of a call with no parameters. The default expiration would be overwritten with the NULL.

[enumag]

@Majkl578 What about this then?

        if ($request === NULL) {
            $request = $this->request;
        } elseif (!$request instanceof Application\Request) {
            $expiration = $request;
            $request = $this->request;
        }

[enumag]

@dg Majkl and I both think this other way is more readable so I force-pushed it. It's ready to merge imho.

[enumag]

ping @dg

[enumag]

Fixed typo in commit message.

[enumag]

I realized that the logic I had in ErrorPresenter shouldn't be there so I moved that elsewhere making this feature useless.

[Majkl578]

@enumag: It is not useless for me, so could you please reopen it?

[enumag]

@Majkl578 ok

[Majkl578]

One mine use case is indirect redirect - e.g. fill in a form, save it to session, then redirect to authentication and afterwards go back directly to next step, say, saving form data from session to database.

[dg]

storeRequest will be moved outside from Presenter. nette/application#4