Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PresenterComponent: now calling checkRequirements() on createComponent<n... #428

Closed
wants to merge 1 commit into from
Closed

PresenterComponent: now calling checkRequirements() on createComponent<n... #428

wants to merge 1 commit into from

Conversation

fprochazka
Copy link
Contributor

No description provided.

@Vrtak-CZ
Copy link
Contributor

Really bad idea! What do you do if create component called from template?

@fprochazka
Copy link
Contributor Author

Well, you shouldn't be doing that anyways, when the user doesn't have the privilege.

<div n:if="$user->isAllowed('component', 'access')">
    {control component}
</div>

@Vrtak-CZ
Copy link
Contributor

I know but it there problem if I forgot do that.

@fprochazka
Copy link
Contributor Author

Better broken rendering than security hole, isn't it?

@dg
Copy link
Member

dg commented Dec 23, 2011

This is the topic for next framework version.

@fprochazka
Copy link
Contributor Author

ping

@f3l1x
Copy link
Member

f3l1x commented Mar 30, 2013

bump

@enumag
Copy link
Contributor

enumag commented Oct 28, 2013

👍 Although I think there should be a test as well (ping @hosiplan).

enumag
enumag reviewed Oct 28, 2013
View reviewed changes
Nette/Application/UI/PresenterComponent.php
$this->checkRequirements($this->getReflection()->getMethod($method));
}

parent::createComponent($name);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing return!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@TomasVotruba
Copy link
Contributor

ping

@dg dg removed this from the 2.2 milestone Jun 19, 2014
@dg dg force-pushed the master branch 3 times, most recently from 991ba1a to e23de7a Compare August 26, 2014 15:04
@TomasVotruba
Copy link
Contributor

TomasVotruba commented Sep 22, 2016 •
edited

Is this still relevant? If so, please feel free to open PR at https://github.com/nette/application

Thank you.

@dg, please close

@enumag
Copy link
Contributor

enumag commented Sep 22, 2016

How did I forget about this? Of course it's still relevant. nette/application#158

@TomasVotruba
Copy link
Contributor

TomasVotruba commented Sep 22, 2016 •
edited

@enumag Thank you, we will continue on the nette/application#158

This can be closed then @dg

@dg
Copy link
Member

dg commented Sep 26, 2016

So I am closing it here.

@dg dg closed this Sep 26, 2016
@TomasVotruba
Copy link
Contributor

Thank you

@fprochazka fprochazka deleted the feature/check-requirements-of-component branch September 27, 2016 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1-feature 2-application 3-is-pullrequest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fprochazka @Vrtak-CZ @dg @f3l1x @enumag @TomasVotruba