Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cqe overflow assert #75

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add cqe overflow assert #75

wants to merge 1 commit into from

Conversation

1Jo1
Copy link
Member

@1Jo1 1Jo1 commented Feb 18, 2021

Motivation:

we need to ensure that the number of lost completion events is always zero to avoid inconsistency

Modifications:

Add a cqe overflow assert

Result:

regarding future core changes, we know when cqe events are lost

Motivation:

we need to ensure that the number of lost completion events is always zero to avoid inconsistency

Modifications:

Add a cqe overflow assert

Result:

regarding future core changes, we know when cqe events are lost
@1Jo1
Copy link
Member Author

1Jo1 commented Feb 18, 2021

tbh it doesnt make sense to add assert to the cqe queue, I think we should move that that to sqe queue

@1Jo1
Copy link
Member Author

1Jo1 commented Feb 18, 2021

it seems we don't track the number of events in io_uring that are not finished, I thought we had something like that, I guess it's probably safer to add that :)

@1Jo1
Copy link
Member Author

1Jo1 commented Feb 18, 2021

another idea would be, just increase the cqe ring size like 3x of sqe size, default is 2x of the sqe size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant