Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epoll: Remove edge-triggered support #14007

Closed
normanmaurer opened this issue Apr 27, 2024 · 0 comments
Closed

Epoll: Remove edge-triggered support #14007

normanmaurer opened this issue Apr 27, 2024 · 0 comments
Assignees
Milestone

Comments

@normanmaurer
Copy link
Member

normanmaurer commented Apr 27, 2024

Back in the days when we wrote the native epoll transport we decided to use edge triggered by default but also support level triggered. Supporting edge-triggered complicates things a lot while the advantage is not really clear with the dispatching model of netty. Let's remove edge-triggered and just use level-triggered.

@normanmaurer normanmaurer added this to the 4.2.0.Final milestone Apr 27, 2024
normanmaurer added a commit that referenced this issue May 3, 2024
…ggered

Motivation:

We supported edge-triggered and level-triggered modes for our epoll transport. This made things more complex while not really providing much value.

Modifications:

- Remove edge-triggered support and just use level-triggered all the time

Result:

Less complexity. Fixes #14007
@normanmaurer normanmaurer self-assigned this May 3, 2024
normanmaurer added a commit that referenced this issue May 3, 2024
#14031)

…ggered

Motivation:

We supported edge-triggered and level-triggered modes for our epoll
transport. This made things more complex while not really providing much
value.

Modifications:

- Remove edge-triggered support and just use level-triggered all the
time

Result:

Less complexity. Fixes #14007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant