Remove edge-triggered support for epoll and just always use level-tri… #14031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ggered Motivation: We supported edge-triggered and level-triggered modes for our epoll transport. This made things more complex while not really providing much value. Modifications: - Remove edge-triggered support and just use level-triggered all the time Result: Less complexity. Fixes #14007
bryce-anderson
approved these changes
May 3, 2024
transport-classes-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollChannel.java
Outdated
Show resolved
Hide resolved
Comment on lines
+568
to
+570
| if (shouldStopReading(config)) { | ||
| clearEpollIn(); | ||
| } |
There was a problem hiding this comment.
fwiw, this whole if block is quite repetitive so maybe it would be a good candidate for a new definition of epollInFinally(Config).
There was a problem hiding this comment.
I was thinking about it but I found it more readable this way :)
There was a problem hiding this comment.
Fair enough reason. It's not a lot of code in any case.
I added it because in theory it should be less expensive. That said it not really gains us much because of how netty works. We still use ET for eventfd and timerfd tho. |
bryce-anderson
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ggered
Motivation:
We supported edge-triggered and level-triggered modes for our epoll transport. This made things more complex while not really providing much value.
Modifications:
Result:
Less complexity. Fixes #14007