codec-http2: Exception as cause, not message format argument #11084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: There are several overloads of streamError(), with one receiving the Throwable to be made the cause of the new exception. However, the wrong overload was being called and instead the IllegalArgumentException was being passed as a message format argument which was summarily thrown away as the message format didn't reference it. Modifications: Move IllegalArgumentException to proper argument position. Result: A useful exception, with the underlying cause available.
|
@ejona86 thanks a lot! |
normanmaurer
pushed a commit
that referenced
this pull request
Mar 14, 2021
Motivation: There are several overloads of streamError(), with one receiving the Throwable to be made the cause of the new exception. However, the wrong overload was being called and instead the IllegalArgumentException was being passed as a message format argument which was summarily thrown away as the message format didn't reference it. Modifications: Move IllegalArgumentException to proper argument position. Result: A useful exception, with the underlying cause available.
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
…1084) Motivation: There are several overloads of streamError(), with one receiving the Throwable to be made the cause of the new exception. However, the wrong overload was being called and instead the IllegalArgumentException was being passed as a message format argument which was summarily thrown away as the message format didn't reference it. Modifications: Move IllegalArgumentException to proper argument position. Result: A useful exception, with the underlying cause available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
There are several overloads of streamError(), with one receiving the
Throwable to be made the cause of the new exception. However, the wrong
overload was being called and instead the IllegalArgumentException was
being passed as a message format argument which was summarily thrown
away as the message format didn't reference it.
Modifications:
Move IllegalArgumentException to proper argument position.
Result:
A useful exception, with the underlying cause available.
CC @Scottmitch
A little something I discovered while working on grpc/grpc-java#7953 (and had a bug in my code).