Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpConnectionHandler should send a GO_AWAY frame with PROTOCOL_ERROR… #12985

Open
wants to merge 2 commits into
base: 4.1
Choose a base branch
from
Open

HttpConnectionHandler should send a GO_AWAY frame with PROTOCOL_ERROR… #12985

wants to merge 2 commits into from

Commits on Nov 11, 2022

  1. HttpConnectionHandler should send a GO_AWAY frame with PROTOCOL_ERROR… 

    … when it receives an unknown stream instead of resetting the stream.

Motivation:

When an HTTP/2 connection process an unnkown stream it should throw a GO_AWAY frame and close the connection as per RFC 7540. The current implementation instead sends a RST frame.

Modifications:

Change the HttpConnectionHandler behavior to throw an error instead of writing a rst frame, the error will trigger a GO_AWAY frame to be sent and then close the connection appropriately.

Result:

HttpConnectionHandler should send a GO_AWAY frame with PROTOCOL_ERROR when it receives an unknown stream and fix netty#12974
    @vietj
    vietj committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    cd00916 View commit details
    Browse the repository at this point in the history

  2. Update codec-http2/src/main/java/io/netty/handler/codec/http2/Http2Co… 

    …nnectionHandler.java
    @normanmaurer
    normanmaurer committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    6189504 View commit details
    Browse the repository at this point in the history