effective_size
of nodes with only self-loop edges is undefined
#7347
+29
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles the corner-case of isolated nodes that contain self-edges. Currently, isolated nodes are treated as having undefined
effective_size
:However, the current behavior for isolated nodes with self-loops is inconsistent, resulting in
ZeroDivisionError
for the undirected case and0.0
for directed graphs::This discrepancy is due to the ambiguity of the direction of a self-edge.
Based on the current behavior and Borgatti's formula, I think the thing that makes the most sense is to have
effective_size
be undefined for all of these cases, making the behavior consistent across the board.Closes #6916