NewRelic - Gin integration - Get status code from a context copy #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @willnewrelic! could you take a look at it? |
|
Hi @nacholupi Thanks for this PR! It is unfortunate that the our small Gin PR fix has not been accepted. If that fix is not merged sometime soon, we will proceed with your alternative. We appreciate your contribution. |
|
Hi @willnewrelic. Your PR was merged! |
|
@nacholupi Indeed @willnewrelic's PR was merged! We are all overjoyed. Thanks for staying up to date on this. I think it's finally safe to close this Pull Request! 🎉 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gin-gonic integration
Write the current status code when "flushHeader()" method is called
This PR is an alternative of this propose:
gin-gonic/gin#1606