re-enable install validation, refactor configuration and profiles modules #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrombley
force-pushed
the
refactor/configuration
branch
2 times, most recently
from
b78c39d
to
6a8916b
Compare
ctrombley
force-pushed
the
refactor/configuration
branch
from
dbd0943
to
9e4dcb4
Compare
ctrombley
force-pushed
the
refactor/configuration
branch
2 times, most recently
from
3c3f7c7
to
b26e5eb
Compare
…nd credentials files
ctrombley
force-pushed
the
refactor/configuration
branch
from
b26e5eb
to
d3ba4b5
Compare
|
Tested on a few linux instances with many re-install scenarios, all worked very well (no profile created during install). |
Julien4218
previously approved these changes
Jul 9, 2021
…ewrelic-cli into refactor/configuration
Julien4218
previously approved these changes
Jul 12, 2021
ctrombley
force-pushed
the
refactor/configuration
branch
2 times, most recently
from
b5a0d10
to
21c68c0
Compare
ctrombley
force-pushed
the
refactor/configuration
branch
from
21c68c0
to
73d71f1
Compare
ctrombley
changed the title
Julien4218
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-enables profile validation for the
installcommand, but also contains a significant refactoring of the code used to store configuration and profile (authentication) information.viperhas been removed as a dependency since it does not provide support for case-sensitive keys, necessary here to allow compatibility with the config file conventions set forth by the NR1 CLI.