chore: testing message output for conditional job handling

newrelic · May 14, 2024 · 72da520 · 72da520
1 parent 6080082
commit 72da520
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 44 deletions.
diff --git a/.github/workflows/graphql-schema.yml b/.github/workflows/graphql-schema.yml
@@ -8,7 +8,8 @@ on:
   #   - cron: '5 5 * * 1'
 
 jobs:
-  downloadSchema:
+  checkForApiUpdates:
+    name: Check for API updates
     runs-on: ubuntu-latest
     steps:
       - name: Install Node
@@ -63,19 +64,19 @@ jobs:
 
       - name: Send report to Slack
         id: slack
-        if: ${{ always() }}
+        if: ${{ steps.schema-diff.outputs.new_endpoints != ''  }}
         uses: slackapi/slack-github-action@v1.26
         with:
           # Uses Slack's Block Kit to build the message
-          # "New Relic Client Go | NerdGraph API Report",
+          # https://app.slack.com/block-kit-builder
           payload: |
             {
               "blocks": [
                 {
                   "type": "section",
                   "text": {
                     "type": "mrkdwn",
-                    "text": "🔎 *NerdGraph API Updates:*"
+                    "text": "🔎 ## New Relic Client Go | NerdGraph API Report"
                   }
                 },
                 {
@@ -93,41 +94,16 @@ jobs:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
           SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
 
-  # uploadSchema:
-  #   runs-on: ubuntu-latest
-  #   steps:
-  #     - name: Install Node
-  #       uses: actions/setup-node@v4
-  #       with:
-  #         node-version: 20.x
-
-  #     - name: Install Go
-  #       uses: actions/setup-go@v5
-  #       with:
-  #         go-version: 1.21.x
-
-  #     - name: Checkout code
-  #       uses: actions/checkout@v3
-
-  #     # - name: Fetch GraphQL Schema
-  #     #   env:
-  #     #     NEW_RELIC_API_KEY: ${{ secrets.NEW_RELIC_API_KEY }}
-  #     #   run: |
-  #     #     go install github.com/newrelic/tutone/cmd/tutone@latest
-  #     #     tutone fetch --refetch
-  #     #     ls
-
-  #     # - name: Check for schema updates
-  #     #   run: ./scripts/schema-diff.js
-
-  #     - name: Upload latest schema.json
-  #       uses: actions/upload-artifact@v4
-  #       with:
-  #         # Duration after which artifact will expire in days. 0 means using default retention.
-  #         # Minimum 1 day.
-  #         # Maximum 90 days unless changed from the repository settings page.
-  #         retention-days: 90
-  #         name: schema
-  #         path: schema.json
-  #         if-no-files-found: error
-  #         overwrite: true
+      # After reporting changes to the schema, upload the most
+      # recent version so we can compare on the next run.
+      - name: Upload latest schema.json
+        uses: actions/upload-artifact@v4
+        with:
+          # Duration after which artifact will expire in days. 0 means using default retention.
+          # Minimum 1 day.
+          # Maximum 90 days unless changed from the repository settings page.
+          retention-days: 90
+          name: schema
+          path: schema.json
+          if-no-files-found: error
+          overwrite: true
diff --git a/scripts/schema-diff.js b/scripts/schema-diff.js
@@ -20,9 +20,9 @@ module.exports = async ({
   const endpointsLatest = schemaLatest.mutationType.fields.map((field) => field.name);
   const endpointsDiff = endpointsLatest.filter(x => !endpointsOld.includes(x));
 
-  console.log("New Endpoints:", endpointsDiff);
+  console.log('New Endpoints:', endpointsDiff);
 
-  let message = "No NerdGraph API updates since the last check."
+  let message = ''
   if (endpointsDiff.length > 0) {
     message = `'${endpointsDiff.join('\n')}'`
   }