Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if getModuleContext is async and instrument accordingly #52

Merged
merged 1 commit into from Mar 30, 2022
Merged

check if getModuleContext is async and instrument accordingly #52

merged 1 commit into from Mar 30, 2022

Conversation

bizob2828
Copy link
Member

@bizob2828 bizob2828 commented Mar 29, 2022 •
edited

Proposed Release Notes

  • Added logic to check if getModuleContext is an async function and instrumenting its return value accordingly.

Links

Closes #51

Details

I put a comment in code but they refactored this function to support WASM and now getModuleContext is async.

Are We Having Fun Yet?

@bizob2828 bizob2828 mentioned this pull request Mar 29, 2022
Merged
@michaelgoin michaelgoin merged commit 419145f into main Mar 30, 2022
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Mar 30, 2022
@michaelgoin michaelgoin deleted the fix-middleware-instrumentation branch March 30, 2022 16:42
@github-actions github-actions bot mentioned this pull request Apr 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelgoin michaelgoin michaelgoin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Middleware tracking fails in > 12.1.2
2 participants
@bizob2828 @michaelgoin