Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamodb instrumentation #2642

Merged
merged 30 commits into from
May 24, 2024
Merged

Dynamodb instrumentation #2642

merged 30 commits into from
May 24, 2024

Conversation

tannalynn
Copy link
Contributor

@tannalynn tannalynn commented May 17, 2024

Adds instrumentation for dynamodb
resolves #2587

@tannalynn tannalynn marked this pull request as ready for review May 17, 2024 19:22
lib/new_relic/agent/aws.rb Outdated Show resolved Hide resolved
lib/new_relic/agent/aws.rb Outdated Show resolved Hide resolved
lib/new_relic/agent/aws.rb Outdated Show resolved Hide resolved
newrelic.yml Outdated Show resolved Hide resolved
test/multiverse/suites/dynamodb/Envfile Show resolved Hide resolved
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great as-is, with a few optional recommendations!

lib/new_relic/agent/instrumentation/dynamodb/chain.rb Outdated Show resolved Hide resolved
lib/new_relic/agent/instrumentation/dynamodb.rb Outdated Show resolved Hide resolved

class DynamodbInstrumentationTest < Minitest::Test
def setup
Aws.config.update(stub_responses: true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sooo convenient. I'm glad you found it.

Copy link

SimpleCov Report

Coverage Threshold
Line 93.79% 93%
Branch 71.09% 71%

@tannalynn tannalynn merged commit c9f14ca into dev May 24, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS: Instrument dynamoDB
3 participants