Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c8 runs out of memory on versioned tests runs #1616

Closed
bizob2828 opened this issue May 2, 2023 · 3 comments · Fixed by #1652
Closed

c8 runs out of memory on versioned tests runs #1616

bizob2828 opened this issue May 2, 2023 · 3 comments · Fixed by #1652

Comments

@bizob2828
Copy link
Member

Is your feature request related to a problem? Please describe.

We've had issues recently where the number of test executions is pushing c8 to the limit and running out of heap memory. We tried working around this by only running versioned tests with c8 when the --major flag is on. This is not foolproof.

Feature Description

Collect coverage on versioned tests that does not cause c8 to run out of memory. One suggestion was to only run nightly and run with SAMPLES=1 to cut down on the version matrix.

Additional context

OOM example

Priority

Please help us better understand this feature request by choosing a priority from the following options:
Must Have

@workato-integration
Copy link

@newrelic-node-agent-team newrelic-node-agent-team added this to Triage Needed: Unprioritized Features in Node.js Engineering Board May 2, 2023
@bizob2828 bizob2828 moved this from Triage Needed: Unprioritized Features to In progress: Issues being worked on in Node.js Engineering Board May 2, 2023
@workato-integration
Copy link

Jira CommentId: 193295
Commented by revans:

I wasn't a fan of any of the bandaids. I will file a PR to extract this portion of the k2 versioned tests so c8 doesn't run on certain runs. But the holistic solution would be to address at the source which is bcoe/c8#469. Hopefully I can get the maintainer to review and merge and release it

@bizob2828 bizob2828 moved this from In progress: Issues being worked on to Needs PR Review in Node.js Engineering Board May 4, 2023
@workato-integration
Copy link

Jira CommentId: 208156
Commented by revans:

PR for agent here #1652

Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Node.js Engineering Board
  
Done: Issues recently completed
1 participant