chore: Update c8 to merge v8 coverage reports asynchronously to avoid OOM issues #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1652 +/- ##
=======================================
Coverage 96.68% 96.68%
=======================================
Files 200 200
Lines 39078 39078
Branches 24 24
=======================================
Hits 37781 37781
Misses 1297 1297
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jmartin4563
approved these changes
May 31, 2023
| @@ -9,6 +9,10 @@ VERSIONED_MODE="${VERSIONED_MODE:---minor}" | |||
| SAMPLES="${SAMPLES:-10}" | |||
| export NODE_OPTIONS="--max-old-space-size=4096" | |||
| SKIP_C8="${SKIP_C8:-false}" | |||
| # In CI we only want to run lcovonly | |||
| # but when running locally we want to see the beautiful | |||
There was a problem hiding this comment.
👏🏻 thank you! i use the html reports all the time
There was a problem hiding this comment.
Do we also want to unleash the koa tests now that c8 supports async merge? Currently they're locked down to a sample of 5, which still results in 128 runs with the minor flag
There was a problem hiding this comment.
I think it's fine to keep
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
May 31, 2023
jmartin4563
added
dev:automation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
My work on c8 was released. This updates the workflows to always run versioned tests with c8 and also use the
--merge-asyncflag to avoid the OOM issues during the report creation.You can see here it works with the minor flag now with no OOM issues: versioned tests with c8 and minor flag, versioned tests with c8 and major flag. Since we can always run c8 I got rid of the nightly versioned test upload. This will make coverage in codecov realtime.
Links
Closes #1616