refactor: Abstracted registering of new aggregators into a Harvester class that is responsible for starting, stopping, updating all registered aggregators. #1994
+751
−812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
class that is responsible for starting, stopping, updating all registered aggregators.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1994 +/- ##
========================================
Coverage 97.04% 97.05%
========================================
Files 218 219 +1
Lines 40493 40129 -364
========================================
- Hits 39297 38946 -351
+ Misses 1196 1183 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jsumners-nr
previously approved these changes
Feb 1, 2024
lib/collector/api.js
Outdated
Comment on lines
89
to
102
| this._methods[name] = method | ||
| } | ||
| } | ||
|
|
||
| CollectorAPI.prototype.send = function send(method, data, callback) { | ||
| if (!callback) { | ||
| this._throwCallbackError() | ||
| } | ||
| if (!data) { | ||
| callback(new TypeError(`must pass data for ${method} to send`)) | ||
| return | ||
| } | ||
|
|
||
| this._sendData(this._methods[method], data, callback) |
There was a problem hiding this comment.
For other people reviewing this: the changes in lines 73-86 are tied to this._methods. This PR is simplifying that mapping.
jsumners-nr
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sorry for the large PR 😬. This PR removes all the places that are necessary to add certain calls when adding a new aggregator. This introduces a harvester class that is responsible for tracking all aggregators. Then depending on stages in the agent it will start, stop, update, and clear the aggregators. To do that I had to update the signature of every aggregator to pass in the harvester instance because registering of an aggregator is done at the construction via
harvest.add. Also I added an evaluator config to determine when an aggregator is enabled based on relevant configuration. Previously this was done instartAggregatorsand was easy to miss when adding a new aggregator.This achieves 1 part of the making it easier to add a new aggregator for the future. I deferred having a common agent method for enqueuing events to another story. The idea behind that is instead of calling the aggregators directly we will have a generic
agent.addEventmethod that takesidandeventandpriority. So right now it'sIt'd be
This functionality will come next. Then we can add the LLM aggregator with its relevant config(still being discussed what the values for config are).
Lastly, I added some missing coverage or made more direct tests around behaviors as it was very difficult to see where things were being tested.
How to Test
Related Issues
Closes #1981